Update Solidity compiler #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add new test directory + Add mocha as development dependency * Change test recipe to call mocha
* Update pragma statement version for new contracts * Update pragma statements for all templates * Update all templates to use the new constructor keyword * Update solc tests to point to new compiler version * Update expected contract bytecode in solc tests to reflect changes
|
Please wait for #176 to be solved before reviewing. |
javier-tarazaga
previously approved these changes
Sep 26, 2018
Resolve conflicts due to changes added during SuperblocksHQ#176
Change reference bytecode to match the new expected compiler output and the new organization format.
|
This request has been updated to reflect the changes made by request #176. |
bashlund
approved these changes
Oct 5, 2018
Merged
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This request updates Solidity compiler to version
0.4.25.Alternate Designs
Not applicable.
Benefits
This changeset works on top of PR #176 and brings the following improvements:
pragma soliditystatement for contracts created with New contract actionpragma soliditystatements for all templatesconstructorlanguage keywordsolctests to point to new compiler versionsolctests to reflect compiler changesPossible Drawbacks
Depends on #176 being accepted (issue #117 must be closed first)
Verification Process
yarn testGithub Issues
This request resolves #30